Missing symbolicEqual from _types/index.d.ts_

[wlewis-formative]

Should symbolicEqual also appear in this file?

If this looks correct, I can open a PR with the changes:

diff --git a/types/index.d.ts b/types/index.d.ts
index 67b9d09aa..fd05af220 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -973,6 +973,21 @@ declare namespace math {
     ): MathNode
     simplifyCore(expr: MathNode | string, options?: SimplifyOptions): MathNode
 
+    /**
+     * Determines if two expressions are symbolically equal, i.e. one is the
+     * result of valid algebraic manipulations on the other.
+     * @param {Node|string} expr1 The first expression to compare
+     * @param {Node|string} expr2 The second expression to compare
+     * @param {Object} [options] Optional option object, passed to simplify
+     * @returns {boolean} Returns true if a valid manipulation making the
+     * expressions equal is found.
+     */
+    symbolicEqual(
+      expr1: MathNode | string,
+      expr2: MathNode | string,
+      options?: SimplifyOptions
+    ): boolean;
+
     /**
      *  Replaces variable nodes with their scoped values
      * @param node Tree to replace variable nodes in

[josdejong]

Thanks for reporting, the function symbolicEqual should indeed be added to the TypeScript definitions. Anyone able to help out here?

[juancodeaudio]

Hi, can I take this issue?

[josdejong]

Yes, thanks Juan!

[Uj293]

Is this issue resolved or not ..??

[josdejong]

@Uj293 there is a PR to fix this, but it is not yet merged or published. It's awaiting feedback from @juancodeaudio .

[Uj293]

@josdejong so i can start working on this too if you assign this one to me

[josdejong]

Thanks, that would be great. Let's await for a day or so to see if Juan replies, if not, I hope he will not mind if you take his PR and finish it.

[josdejong]

@Uj293 we didn't yet hear back from Juan. Can you take over his PR? Thanks!

[josdejong]

The types have been fixed now in in v11.12.0, fixed via #3035.

[wlewis-formative]

Thanks everyone!