Wrong calculation in derivative with unaryMinus

[gpaucot]

var math = require('mathjs'); // 3.16.2

console.log(math.derivative('1 - 2 * x', 'x').toString());       // => -2 ok
console.log(math.derivative('1 - +2 * x', 'x').toString());      // => -2 ok
console.log(math.derivative('1 - -2 * x', 'x').toString());      // => -2 not ok, should be 2
console.log(math.derivative('1 - (-2) * x', 'x').toString());    // => -2 not ok, should be 2
console.log(math.derivative('1 - (-2 * x)', 'x').toString());    // => -2 not ok, should be 2
console.log(math.derivative('1 - ((-2) * x)', 'x').toString());  // => -2 not ok, should be 2
console.log(math.derivative('-((-2) * x) - 1', 'x').toString()); // => -2 not ok, should be 2

BTW awesome work guys thanks ! 👍

[josdejong]

Thanks for reporting this bug @gpaucot

[josdejong]

It looks like this issue is originating in simplify and not in derivative:

math.derivative('1 - -2x', 'x', {simplify: false}).toString(); // Correct: 0 - -2 * 1
math.simplify('0 - -2 * 1').toString()  // Wrong: -2

Or simpler:

math.simplify('--2') // Wrong: -2 (should be 2)

[firepick1]

EEK! I'm on it. Sorry for the delay--was having fun elsewhere. 😢

[firepick1]

Fixed in simplify2 5b175d5
Added unit test for double unaryMinus. @jos thanks for triage and diagnosis.

[gpaucot]

Thank you very much both ! ;)

[josdejong]

Thanks @firepick1 for picking this up, I couldn't immediately pinpoint the underlying cause.

[josdejong]

This should be fixed now in v3.16.3