Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(mod) Bug #3008

Closed
wants to merge 1 commit into from
Closed

(mod) Bug #3008

wants to merge 1 commit into from

Conversation

Sakira-42
Copy link

I worked on solving the bug mod() that sometimes returns an unexpected result, presumably due to round-off errors.

The bug is on line 161 in the arithmetic.js file.

…d result, presumably due to round-off errors.
@Yaffle
Copy link
Contributor

Yaffle commented Aug 12, 2023

Usage of Decimal is probably much slower. Is it possible Instead to manipulatie the sign of operands or adjust the result of %?

@josdejong
Copy link
Owner

Thanks Yaffle for your PR. I will close this PR in favor of #3011 which is more in line with the plan discussed in #2936, ok?

@josdejong josdejong closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants