Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2919 type exports manual #3079

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Fix/2919 type exports manual #3079

merged 5 commits into from
Oct 26, 2023

Conversation

josdejong
Copy link
Owner

@josdejong josdejong commented Oct 12, 2023

Fix #2919 using the approach of Maxim worked out in #2932.

Changes:

  • Renamed MathJsStatic into MathJsInstance
  • The dependencies are no longer exported in MathJsInstance (they are not exported there in reality)
  • Export all functions and constants of MathJsInstance as static constants.
  • Document how to properly define types in types/EXPLANATION.md

To do:

  • Bring the types up to date with all changes done in the v12 branch
  • Test thoroughly

@josdejong josdejong merged commit 544b86f into v12 Oct 26, 2023
9 checks passed
@josdejong josdejong deleted the fix/2919_type_exports_manual branch October 26, 2023 09:39
@josdejong josdejong mentioned this pull request Oct 26, 2023
@josdejong josdejong added this to the v12 milestone Oct 26, 2023
@josdejong
Copy link
Owner Author

Published now in v12.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant