Remove unnecessary console logging on Unit.js

[eknkc]

No description provided.

[FSMaxB]

Thanks for spotting this one.

Please do pull requests on the develop branch, not master.

Looking into this, I found some other calls to console.log in lib/function/arithmetic/xgcd.js that are commented out but still in the code. @josdejong: Should they be removed?

Here's a list for commit 1c12fb2:

• 109: //console.log('start', [a, b].toString())
• 112: //console.log('inner', [a, b, t, q, r, x, y, lastx, lasty].toString());
• 115: //console.log('MOD', [a, b, a.mod(b), r].toString())
• 128: //console.log('inner end', [a, b, t, q, r, x, y, lastx, lasty].toString());
• 131: //console.log('end', [a, lastx, lasty].toString())

[FSMaxB]

I'll merge this for now, the other console.log's can be removed later.

[ThomasBrierley]

These could be caught by a linter, I use eslint which is highly configurable and has a "console.log" option... although I realise it might be a bit painful to start adding linting rules now.

[josdejong]

Thanks @eknkc for this patch.

@FSMaxB I've removed the commented console.logs. They don't do harm but it's a bit sloppy.

@ThomasBrierley we can certainly add a linter. Will be interesting to see whether we catch a lot of issues. In first instance we could run the linter as a separate script just to see what it does. Would you like to give this a try?

[josdejong]

I've just released v3.5.1 having with the logging removed.

[ThomasBrierley]

Sure, I'll start with an eslint file and stick to style agnostic "good practice" rules for now and see how it goes. That can be run selectively and recursively within the repo by using a globally installed eslint module.

If it turns out to be useful and easy enough to conform existing code then it should be pretty easy to integrate into the gulp file / travis etc.