Support more than two operands in OperatorNode for addition and multiplication #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for the next step, where the conditions will get complexer than a simple switch case.
Only for multiplication and addition though.
josdejong
reviewed
Nov 13, 2016
| parens = false; | ||
| } | ||
|
|
||
| parensArray.push(parens); |
There was a problem hiding this comment.
Maybe you can use var parensArray = args.map(function () {}) instead of a forEach and parensArray.push?
There was a problem hiding this comment.
I wasn't too familiar with Array.prototype.map. I'll take a look at it tomorrow.
|
Looks good 👍 You could replace I will adjust |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #739