Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use event.target in cases where _firstTarget has been removed from DOM #17

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Use event.target in cases where _firstTarget has been removed from DOM #17

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f2214b
Use event.target in cases where _first target has been removed from DOM
sgparrish Dec 27, 2023
277ecfa
Replace document.contains with node walking and checking nodeType
sgparrish Jan 11, 2024
9dad9fa
rework to use `isConnected`
sgparrish Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/propagating.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export default function propagating(hammer, options) {
event.firstTarget = _firstTarget;

// propagate over all elements (until stopped)
var elem = _firstTarget;
var elem = _firstTarget.isConnected ? _firstTarget : event.target;
while (elem && !stopped) {
var elemHammer = elem.hammer;
if(elemHammer){
Expand Down