perf(diagnostics): ignore didSave notification if buffer unchanged

jose-elias-alvarez · Nov 12, 2021 · 81bdb29 · 81bdb29
1 parent a3406ba
commit 81bdb29
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lua/null-ls/diagnostics.lua b/lua/null-ls/diagnostics.lua
@@ -92,10 +92,16 @@ M.handler = function(original_params)
         s.clear_cache(uri)
     end
 
-    local params = u.make_params(original_params, methods.map[method])
     local bufnr = vim.uri_to_bufnr(uri)
-
     local changedtick = original_params.textDocument.version or api.nvim_buf_get_changedtick(bufnr)
+
+    if method == methods.lsp.DID_SAVE and changedtick == last_changedtick[uri] then
+        u.debug_log("buffer unchanged; ignoring didSave notification")
+        return
+    end
+
+    local params = u.make_params(original_params, methods.map[method])
+
     last_changedtick[uri] = changedtick
 
     require("null-ls.generators").run_registered({

diff --git a/test/spec/diagnostics_spec.lua b/test/spec/diagnostics_spec.lua
@@ -67,7 +67,7 @@ describe("diagnostics", function()
         it("should call make_params with params and method", function()
             diagnostics.handler(mock_params)
 
-            assert.stub(u.make_params).was_called_with(mock_params, methods.internal.DIAGNOSTICS)
+            assert.stub(u.make_params).was_called_with(mock_params, methods.internal.DIAGNOSTICS_ON_OPEN)
         end)
 
         describe("handler", function()