goimports-reviser undoing recent changes on save

[kcaashish]

I have raised this issue in goimports-reviser as well. Upon saving the changes, the recent changes get undone while using goimports-reviser. Is this something to do with null-ls?

My config for goimports-reviser is:

return {
  {
    "jose-elias-alvarez/null-ls.nvim",
    opts = function(_, opts)
      local nls = require("null-ls")
      local nls_sources = {
        -- go
        nls.builtins.formatting.goimports_reviser.with({
          generator_opts = {
            command = "goimports-reviser",
            args = { "-output", "stdout", "$FILENAME" },
            to_stdin = true,
          },
        }),
      }
      vim.list_extend(opts.sources, nls_sources, 1, #nls_sources)
    end,
  },
}

In a very simple go project with go.mod:

module minimal

go 1.19

main.go:

package main

func main() {
	fmt.Println("Hello, World!")
}

Notice the absence of imports statment as well. So there should be a undeclared name: fmt error.

If I delete the line fmt.Println() dd then hit :w, the line pops back up.

Screencast.from.2023-03-24.14-10-39.webm

[jose-elias-alvarez]

You are modifying the source's original arguments in a way that may be causing the problem. If you are able to replicate this with the original source, can you please open an issue?

[jose-elias-alvarez]

I see, I will take a closer look at this then.

[kcaashish]

Thank you, it has been bugging me for a week now. FYI I opened an issue at goimports-reviser but it didn't receive a proper response other than to look over to null-ls. incu6us/goimports-reviser#112

[jose-elias-alvarez]

So the issue here is that based on this issue, the CLI doesn't actually support stdin. We can work around this with the following changes:

diff --git a/lua/null-ls/builtins/formatting/goimports_reviser.lua b/lua/null-ls/builtins/formatting/goimports_reviser.lua
index 77e68c7..cbbe024 100644
--- a/lua/null-ls/builtins/formatting/goimports_reviser.lua
+++ b/lua/null-ls/builtins/formatting/goimports_reviser.lua
@@ -13,8 +13,8 @@ return h.make_builtin({
     filetypes = { "go" },
     generator_opts = {
         command = "goimports-reviser",
-        args = { "-file-path", "$FILENAME", "-output", "stdout" },
-        to_stdin = true,
+        args = { "$FILENAME" },
+        to_temp_file = true,
     },
     factory = h.formatter_factory,
 })

But for various reasons, using temp files is not ideal. It would be great if we could get this fixed upstream, but for now I think the above is the right fix.

[kcaashish]

Great! This solves the issue I was having. Thank you!

Now, for the time being, until the upstream supports stdin, this should work. So, should I update my pr #1464 to reflect this change?

[jose-elias-alvarez]

Yep, I think that would be the best solution for now.