This repository has been archived by the owner on Aug 12, 2023. It is now read-only.
fix(goimports_reviser): remove the deprecated -file-path arg #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To determine if we need to announce this as a breaking change: how do older versions behave with the new argument structure? |
|
Hey @jose-elias-alvarez, this change is needed because of the depreciation of the If there is something I could look at to improve the behavior, I would make necessary changes after that. Please check the discussion: #1472 |
|
Thanks! Good idea to put the note there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the deprecated -file-path arg and moved $FILENAME to the end as suggested. incu6us/goimports-reviser@979c6e7
EDIT: based on the discussion #1472, using temp file for now, till the issue with
stdingets resolved upstream.