This repository has been archived by the owner on Aug 12, 2023. It is now read-only.
fix(builtins): add golangci_lint support for monorepos #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnevm123
changed the title
arnevm123
force-pushed
the
fix/builtins-golangci-lint-add_monorepo_support
branch
from
fa7c270
to
f691402
Compare
|
LGTM, thanks for picking this up! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had issues trying to get golangci-lint to work in a monorepo.
I believe this shoud fix the issue. While trying to figure this out myself I also found #1206 which helped me fix the issue, but seems stale.
Please let me know if anything needs to change.
I've also added a space to the string formatting as this looks more in line with for example eslint_d output