Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonadIO instance #29

Closed
chris-martin opened this issue May 16, 2023 · 4 comments · Fixed by #30
Closed

MonadIO instance #29

chris-martin opened this issue May 16, 2023 · 4 comments · Fixed by #30
Assignees
@andreasabel
Labels
enhancement
Milestone
0.4.7

Comments

@chris-martin
Copy link

Would a pull request adding a MonadIO instance be welcome?

instance (MonadIO m) => MonadIO (STT s m) where
    liftIO x = lift (liftIO x)

This would require raising the minimum base version to 4.9 (GHC 8.0, released in 2016).
@andreasabel
Copy link
Collaborator

This would require raising the minimum base version to 4.9 (GHC 8.0, released in 2016).

Or using a conditional...

@chris-martin
Copy link
Author

What's this package's policy for when to drop support for old versions?

@andreasabel
Copy link
Collaborator

We could also explicitly depend on transformers, which we now implicitly do via mtl. Then we would have MonadIO independent of base.
This is better than having a conditional instance.

@andreasabel andreasabel mentioned this issue May 17, 2023
Merged
@andreasabel andreasabel self-assigned this May 18, 2023
@andreasabel andreasabel added this to the 0.4.7 milestone May 18, 2023
@andreasabel
Copy link
Collaborator

Published as 0.4.7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasabel andreasabel

Labels
enhancement
Projects
None yet
Milestone
0.4.7
Development

Successfully merging a pull request may close this issue.

Add MonadIO instance josefs/STMonadTrans
2 participants
@chris-martin @andreasabel