Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

UrlPropertyHandler does not work correctly for some cases #24

Closed
mickiewicz opened this issue Oct 3, 2018 · 1 comment
Closed

UrlPropertyHandler does not work correctly for some cases #24

mickiewicz opened this issue Oct 3, 2018 · 1 comment

Comments

@mickiewicz
Copy link

mickiewicz commented Oct 3, 2018 •
edited
Loading

I think UrlPropertyHandler currently doesn't work as it should. Now it checks if a url is absolute, I think it should checks if the link is external instead. For internal it should call:
this._urlHelper.ContentUrl(url, contentSerializerSettings.UrlSettings)
Please check two failing tests.
@joseftw
Copy link
Owner

joseftw commented May 15, 2019

Could you provide more information? Maybe add a PR with a failing test? All tests are green for me.

@joseftw joseftw closed this as completed May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joseftw @mickiewicz