Table::convertToEntity limits to use id key

[simonberger]

In Table::convertToEntity there is a a check on a set id field

if (is_null($data) || empty($data[$this->alias]['id'])) {

My sight in this plugin isn't deep enough to understand if this limitation is needed, but if we change this to

if (is_null($data) || empty($data[$this->alias][$this->primaryKey])) {

this works in first short tests and we don't have to change our models to use id fields

[josegonzalez]

Thanks for the bug report!

[josegonzalez]

How are you liking/disliking these changes so far? Anything missing from this plugin that you think we should add?

[simonberger]

Thank you for the fast reaction and confirmation of my assumption!

At the moment we are happy with the functionality of your plugin. I'll post here again if we find anything that could be needed or should be fixed.