Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Datasource Configuration for Queuesadilla #3

Closed
robertscherer opened this issue Jul 5, 2016 · 3 comments
Closed

Use Datasource Configuration for Queuesadilla #3

robertscherer opened this issue Jul 5, 2016 · 3 comments

Comments

@robertscherer
Copy link

When using the Plugin in a standard CakePHP application with a PDO-based engine, it practically forces you to configure the database credentials twice in the app's configuration.

I think it'd be a good idea to re-use the Datasource configs for configuration DB access for queuesadilla, which would be especially useful when writing unit tests.

@josegonzalez Do you think this brings inconsistency to configuration when using non-PDO-based engines?

@josegonzalez
Copy link
Owner

Probably, but the key naming should be the same for all of them, so I don't think it's an issue.

@josegonzalez
Copy link
Owner

One thing I do is use environment variables for configuring queuesadilla, so it's really only one key that I am duplicating.

@josegonzalez
Copy link
Owner

Yeah I'm going to close this. I don't think it makes sense, given the ability to use the url key for configuring the DSN and sharing it with PDO-based drivers. I highly recommend doing that, as it's what I do in my own app-skeleton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants