Move data type method conditional outside of loop

python-beaver · Jun 10, 2015 · 94812db · 94812db
1 parent b970bda
commit 94812db
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/beaver/transports/redis_transport.py b/beaver/transports/redis_transport.py
@@ -84,19 +84,18 @@ def callback(self, filename, lines, **kwargs):
 
         pipeline = server['redis'].pipeline(transaction=False)
 
+        if data_type == 'list':
+            data_type_method = pipeline.rpush
+        elif data_type == 'channel':
+            data_type_method = pipeline.publish
+        else:
+            raise TransportException('Unknown Redis data type')
+
         for line in lines:
-            if data_type == 'list':
-                pipeline.rpush(
-                    namespace,
-                    self.format(filename, line, timestamp, **kwargs)
-                )
-            elif data_type == 'channel':
-                pipeline.publish(
-                    namespace,
-                    self.format(filename, line, timestamp, **kwargs)
-                )
-            else:
-                raise TransportException('Unknown Redis data type')
+            data_type_method(
+                namespace,
+                self.format(filename, line, timestamp, **kwargs)
+            )
 
         try:
             pipeline.execute()