-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to be more easily importable #50
Comments
Go for it. Honestly, I more or less merge anything that doesn't break functionality I use, so if you think this is a good move, thats fine by me. |
Doesn't seem like this is going to happen, but PRs welcome :) |
I apologize for bumping a dead issue, but thought I could mention a workaround I put together until a PR gets made addressing this. I used some
You can then pump arguments into sys.argv before calling github_backup.main(), though I did it before this oddball loading business. EDIT: |
@josegonzalez Is there a particular reason for structuring the module such that the actual code resides in What was the motivation for putting the code in the |
None, other than it was a very small binary before and I didn't see a need to put it into the namespace. |
@josegonzalez are there any functions you wouldn't want exposed when the library gets imported? |
I don't really care to be honest. I've been merging almost every pull request, so go nuts. |
josegonzalez#50: refactor for friendlier import
josegonzalez#50 update: undid imports in __init__
#50 - refactor for friendlier import
The github-backup package cannot be importable because of how its named. I think most of the code should be moved to the github_backup source code and the executable script file should be minimal. This will help with #49 and for writing code that calls this as a library.
The text was updated successfully, but these errors were encountered: