Backup regular pull request comments as well #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, only review comments were backed up; regular comments need to be fetched via issue API. Fixes: josegonzalez#150
TheOneric
force-pushed
the
pull_backup-regular-comments
branch
from
21737af
to
b629a86
Compare
TheOneric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, only review comments were backed up; regular comments need to be fetched via issue API.
Fixes: #150
Approach taken from #150.
I kept the
comment_dataname for reviews to not break incremental backups from old versions. However iinm, to get all regular comments also for older PRs a fresh backup from scratch will be required.