Break parser into entity focused parsers #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israel-hdez
commented
Nov 23, 2017
israel-hdez
commented
- Refresher class is now inheriting from ManagerRefresher. This forces to include a builder class, which creates the required parser, collector and persister objects when the refresh is happening.
- In the settings file, a new property is added. Because now the refresher is inheriting from ManagerRefresher, targeted refresh must be explicitly enabled.
- The parser has been broken into multiple parsers. This is in preparation to implement targeted refresh.
israel-hdez
force-pushed
the
targeted-refresh-prep
branch
2 times, most recently
from
2e3e664
to
d162c86
Compare
* Refresher class is now inheriting from ManagerRefresher. This forces to include a builder class, which creates the required parser, collector and persister objects when the refresh is happening. * In the settings file, a new property is added. Because now the refresher is inheriting from ManagerRefresher, targeted refresh must be explicitly enabled. * The parser has been broken into multiple parsers. This is in preparation to implement targeted refresh.
…files The specs changed its form. Now, the specs aren't using the protected nor private methods to check behaviours. The old parser/middleware_manager_spec.rb file is now removed since it is now replaced by the new files.
israel-hdez
force-pushed
the
targeted-refresh-prep
branch
from
d162c86
to
68d3f51
Compare
israel-hdez
changed the title
|
@josejulio You can now merge into your fork. |
|
@israel-hdez rubocop is complaing, can you make it happy? :) |
|
Yes... I'll do. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.