Skip to content
This repository has been archived by the owner on Feb 18, 2023. It is now read-only.

Feat request : upgrade Laravel passport to version 3.0.0 #16

Closed
kslimani opened this issue Jul 12, 2017 · 2 comments
Closed

Feat request : upgrade Laravel passport to version 3.0.0 #16

kslimani opened this issue Jul 12, 2017 · 2 comments
Assignees
@joselfonseca
Labels
enhancement
Milestone
3.1.0

Comments

@kslimani
Copy link
Contributor

kslimani commented Jul 12, 2017 •
edited

I think it would be nice to upgrade laravel/passport to ^3.0 which will also upgrade league/oauth2-server to 6.0.0.

I locally upgraded and run tests and they all passed.

Motivations is it fixes security issues.

Here the diff for passport from 2.0.11 to 3.0.0. I don't see major breaking changes, except for the key encrypt part fix. (but you may want to double check this).

Here the diff for oauth from 5.1.3 to 6.0.0. Major changes seems to be related to file permissions for key files. (you may also want to double check this).

EDIT: for League oauth server, it seems it require one line to be changed.
@joselfonseca
Copy link
Owner

Great catch, I though i did it before. I will update this repo today. Thanks!

@joselfonseca joselfonseca self-assigned this Jul 12, 2017
@joselfonseca joselfonseca modified the milestones: 3.1.0, 3.0.2 Jul 12, 2017
joselfonseca added a commit that referenced this issue Jul 12, 2017
@joselfonseca
#17 remove command bus in favor of Laravel Pipeline class
8087c3f 
#16 Upgrade passport to 3.0
@joselfonseca joselfonseca modified the milestones: 3.1.0, 3.0.2 Jul 12, 2017
@joselfonseca
Copy link
Owner

Fixed here https://github.com/joselfonseca/laravel-api/releases/tag/3.1.0

@sbn111 sbn111 mentioned this issue Mar 12, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joselfonseca joselfonseca

Labels
enhancement
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
2 participants
@kslimani @joselfonseca