Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overwrite feature #5

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Add overwrite feature #5

merged 3 commits into from
Dec 26, 2023

Conversation

st0le
Copy link

@st0le st0le commented Dec 22, 2023 •
edited
Loading

Allow enve to override Environment variables already set.

@codecov Codecov
Copy link

codecov bot commented Dec 23, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@joseluisq joseluisq added the enhancement New feature or request label Dec 24, 2023
@joseluisq joseluisq self-requested a review December 24, 2023 12:38
joseluisq
joseluisq requested changes Dec 24, 2023
View reviewed changes
Copy link
Owner

@joseluisq joseluisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like the idea.
Just tackle please those minor changes and the PR should be ready to go.

cmd/cmd.go Outdated Show resolved Hide resolved
cmd/cmd.go Outdated Show resolved Hide resolved
cmd/cmd.go Outdated Show resolved Hide resolved
@st0le st0le requested a review from joseluisq December 25, 2023 20:05
joseluisq
joseluisq approved these changes Dec 26, 2023
View reviewed changes
Copy link
Owner

@joseluisq joseluisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joseluisq joseluisq merged commit cf5dbb2 into joseluisq:master Dec 26, 2023
11 checks passed
@joseluisq
Copy link
Owner

Delivered on v1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseluisq joseluisq joseluisq approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@st0le @joseluisq