Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: Add Embroider #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Site: Add Embroider #53

wants to merge 2 commits into from

Conversation

josemarluedke
Copy link
Owner

@josemarluedke josemarluedke commented Sep 6, 2020

TODO:

@kiwiupover
Copy link

@josemarluedke Wanted to look at this issue but can get the app to build. I'm running into issues like this.

2 import { Context } from '@docfy/core/lib/types';
                          ~~~~~~~~~~~~~~~~~~~~~~~

src/plugins/replace-internal-links-with-docfy-link.ts:2:38 - error TS2307: Cannot find module '@docfy/core/lib/types' or its corresponding type declarations.

2 import { Context, PageContent } from '@docfy/core/lib/types';
                                       ~~~~~~~~~~~~~~~~~~~~~~~

@josemarluedke
Copy link
Owner Author

@kiwiupover thanks for your interest in looking at this. For development, you do need to build the core first for the types to be generated.

  1. cd packages/@docfy/core
  2. yarn compile

I hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants