Merge pull request #49 from josemarluedke/feat/eslint-config

New eslint-config & Prettier v2.0.0
josemarluedke · Mar 26, 2020 · a4334d6 · a4334d6
2 parents fd0dca9 + 91e08fc
commit a4334d6
Show file tree

Hide file tree

Showing 73 changed files with 360 additions and 392 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -6,7 +6,7 @@ module.exports = {
     project: join(__dirname, './tsconfig.eslint.json')
   },
   plugins: [],
-  extends: ['@neighborly/eslint-config-ember-typescript'],
+  extends: ['@underline/eslint-config-ember-typescript'],
   rules: {
     '@typescript-eslint/no-empty-interface': 'off'
   },
@@ -38,7 +38,7 @@ module.exports = {
         'packages/*/addon/tailwind/*.js',
         'packages/tailwindcss-plugin-helpers/**/*.js'
       ],
-      extends: ['@neighborly/eslint-config-node'],
+      extends: ['@underline/eslint-config-node'],
       rules: {}
     }
   ]

diff --git a/.prettierrc.js b/.prettierrc.js
@@ -1 +1 @@
-module.exports = require('@neighborly/eslint-config/.prettierrc.js');
+module.exports = require('@underline/eslint-config/.prettierrc.js');
diff --git a/config/ember-try.js b/config/ember-try.js
@@ -2,12 +2,12 @@
 
 const getChannelURL = require('ember-source-channel-url');
 
-module.exports = function() {
+module.exports = function () {
   return Promise.all([
     getChannelURL('release'),
     getChannelURL('beta'),
     getChannelURL('canary')
-  ]).then(urls => {
+  ]).then((urls) => {
     return {
       useYarn: true,
       scenarios: [

diff --git a/package.json b/package.json
@@ -13,8 +13,8 @@
     "try:one": "yarn workspaces run try:one"
   },
   "devDependencies": {
-    "@neighborly/eslint-config-ember-typescript": "^0.6.0",
-    "@neighborly/eslint-config-node": "^0.6.0",
+    "@underline/eslint-config-ember-typescript": "^0.7.0",
+    "@underline/eslint-config-node": "^0.7.0",
     "ember-source-channel-url": "^2.0.1",
     "ember-template-lint": "^2.4.1",
     "eslint": "^6.8.0",

diff --git a/packages/buttons/addon/tailwind/index.js b/packages/buttons/addon/tailwind/index.js
@@ -1,8 +1,8 @@
 const plugin = require('tailwindcss/plugin');
 const { resolve, isEmpty } = require('@frontile/tailwindcss-plugin-helpers');
 
-module.exports = plugin.withOptions(function(userConfig) {
-  return function({ addComponents, theme }) {
+module.exports = plugin.withOptions(function (userConfig) {
+  return function ({ addComponents, theme }) {
     const { options } = resolve(
       '@frontile/buttons',
       require('./default-options'),
@@ -46,7 +46,7 @@ module.exports = plugin.withOptions(function(userConfig) {
       }
     }
 
-    Object.keys(options).forEach(key => {
+    Object.keys(options).forEach((key) => {
       const modifier = key === 'default' ? '' : `-${key}`;
       addButton(options[key].button, modifier);
     });

diff --git a/packages/buttons/config/environment.js b/packages/buttons/config/environment.js
@@ -1,5 +1,5 @@
 'use strict';
 
-module.exports = function(/* environment, appConfig */) {
+module.exports = function (/* environment, appConfig */) {
   return {};
 };
diff --git a/packages/buttons/ember-cli-build.js b/packages/buttons/ember-cli-build.js
@@ -3,7 +3,7 @@
 const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
 const path = require('path');
 
-module.exports = function(defaults) {
+module.exports = function (defaults) {
   const app = new EmberAddon(defaults, {
     postcssOptions: {
       compile: {

diff --git a/packages/buttons/tests/dummy/app/router.js b/packages/buttons/tests/dummy/app/router.js
@@ -6,6 +6,6 @@ export default class Router extends EmberRouter {
   rootURL = config.rootURL;
 }
 
-Router.map(function() {
+Router.map(function () {
   // there are no routes in this dummy app
 });
diff --git a/packages/buttons/tests/dummy/config/environment.js b/packages/buttons/tests/dummy/config/environment.js
@@ -1,6 +1,6 @@
 'use strict';
 
-module.exports = function(environment) {
+module.exports = function (environment) {
   const ENV = {
     modulePrefix: 'dummy',
     environment,

diff --git a/packages/buttons/tests/integration/components/button-test.ts b/packages/buttons/tests/integration/components/button-test.ts
@@ -3,17 +3,17 @@ import { setupRenderingTest } from 'ember-qunit';
 import { render } from '@ember/test-helpers';
 import hbs from 'htmlbars-inline-precompile';
 
-module('Integration | Component | Button', function(hooks) {
+module('Integration | Component | Button', function (hooks) {
   setupRenderingTest(hooks);
 
-  test('it renders', async function(assert) {
+  test('it renders', async function (assert) {
     await render(hbs`<Button data-test-id="button">My Button</Button>`);
 
     assert.dom('[data-test-id="button"]').hasText('My Button');
     assert.dom('[data-test-id="button"]').hasAttribute('type', 'button');
   });
 
-  test('it accepts @type argument', async function(assert) {
+  test('it accepts @type argument', async function (assert) {
     await render(
       hbs`<Button @type="submit" data-test-id="button">My Button</Button>`
     );
@@ -23,13 +23,13 @@ module('Integration | Component | Button', function(hooks) {
 
   module('Style classes', () => {
     module('@appearance', () => {
-      test('it adds class for default appearance', async function(assert) {
+      test('it adds class for default appearance', async function (assert) {
         await render(hbs`<Button data-test-id="button">My Button</Button>`);
 
         assert.dom('[data-test-id="button"]').hasClass('btn');
       });
 
-      test('it adds class for outlined appearance', async function(assert) {
+      test('it adds class for outlined appearance', async function (assert) {
         await render(
           hbs`<Button @appearance="outlined" data-test-id="button">My Button</Button>`
         );
@@ -39,7 +39,7 @@ module('Integration | Component | Button', function(hooks) {
         assert.dom('[data-test-id="button"]').hasClass('btn-outlined');
       });
 
-      test('it adds class for outlined appearance', async function(assert) {
+      test('it adds class for outlined appearance', async function (assert) {
         await render(
           hbs`<Button @appearance="minimal" data-test-id="button">My Button</Button>`
         );
@@ -51,7 +51,7 @@ module('Integration | Component | Button', function(hooks) {
     });
 
     module('@intent', () => {
-      test('it adds class for the an intent', async function(assert) {
+      test('it adds class for the an intent', async function (assert) {
         await render(
           hbs`<Button @intent="primary" data-test-id="button">My Button</Button>`
         );
@@ -65,7 +65,7 @@ module('Integration | Component | Button', function(hooks) {
           .doesNotHaveClass('btn-minimal-primary');
       });
 
-      test('it adds class for the an intent with appearance=outlined', async function(assert) {
+      test('it adds class for the an intent with appearance=outlined', async function (assert) {
         await render(
           hbs`<Button
                 @appearance="outlined"
@@ -83,7 +83,7 @@ module('Integration | Component | Button', function(hooks) {
           .doesNotHaveClass('btn-minimal-primary');
       });
 
-      test('it adds class for the an intent with appearance=minimal', async function(assert) {
+      test('it adds class for the an intent with appearance=minimal', async function (assert) {
         await render(
           hbs`<Button
                 @appearance="minimal"
@@ -103,39 +103,39 @@ module('Integration | Component | Button', function(hooks) {
     });
 
     module('sizes', () => {
-      test('it adds class @isXSmall', async function(assert) {
+      test('it adds class @isXSmall', async function (assert) {
         await render(
           hbs`<Button @isXSmall={{true}} data-test-id="button">My Button</Button>`
         );
 
         assert.dom('[data-test-id="button"]').hasClass('btn-xs');
       });
 
-      test('it adds class @isSmall', async function(assert) {
+      test('it adds class @isSmall', async function (assert) {
         await render(
           hbs`<Button @isSmall={{true}} data-test-id="button">My Button</Button>`
         );
 
         assert.dom('[data-test-id="button"]').hasClass('btn-sm');
       });
 
-      test('it adds class @isLarge', async function(assert) {
+      test('it adds class @isLarge', async function (assert) {
         await render(
           hbs`<Button @isLarge={{true}} data-test-id="button">My Button</Button>`
         );
 
         assert.dom('[data-test-id="button"]').hasClass('btn-lg');
       });
 
-      test('it adds class @isXLarge', async function(assert) {
+      test('it adds class @isXLarge', async function (assert) {
         await render(
           hbs`<Button @isXLarge={{true}} data-test-id="button">My Button</Button>`
         );
 
         assert.dom('[data-test-id="button"]').hasClass('btn-xl');
       });
 
-      test('it adds class @isLarge with appearance', async function(assert) {
+      test('it adds class @isLarge with appearance', async function (assert) {
         await render(
           hbs`<Button @appearance="outlined" @isLarge={{true}} data-test-id="button">My Button</Button>`
         );
@@ -145,7 +145,7 @@ module('Integration | Component | Button', function(hooks) {
     });
   });
 
-  test('it yields classNames when renderless', async function(assert) {
+  test('it yields classNames when renderless', async function (assert) {
     await render(
       hbs`<Button @isRenderless={{true}} as |btn|>
             <div data-test-id="my-div">{{btn.classNames}}</div>

diff --git a/packages/changeset-form/addon/components/changeset-form/fields/base.ts b/packages/changeset-form/addon/components/changeset-form/fields/base.ts
@@ -41,7 +41,7 @@ export default class ChangesetFormFieldsBase<
       return this.args.errors;
     }
 
-    const fieldErrors = this.args.changeset.errors.filter(error => {
+    const fieldErrors = this.args.changeset.errors.filter((error) => {
       return error.key === this.args.fieldName;
     });
 

diff --git a/packages/changeset-form/addon/components/changeset-form/fields/checkbox-group.ts b/packages/changeset-form/addon/components/changeset-form/fields/checkbox-group.ts
@@ -32,7 +32,7 @@ export default class ChangesetFormFieldsCheckboxGroup extends Component<
       return [];
     }
 
-    const fieldErrors = this.args.changeset.errors.filter(error => {
+    const fieldErrors = this.args.changeset.errors.filter((error) => {
       return error.key === this.args.groupName;
     });
 

diff --git a/packages/changeset-form/addon/components/changeset-form/fields/checkbox.ts b/packages/changeset-form/addon/components/changeset-form/fields/checkbox.ts
@@ -26,7 +26,7 @@ export default class ChangesetFormFieldsCheckbox extends Base<
       return this.args.errors;
     }
 
-    const fieldErrors = this.args.changeset.errors.filter(error => {
+    const fieldErrors = this.args.changeset.errors.filter((error) => {
       return error.key === this.fullFieldName;
     });
 

diff --git a/packages/changeset-form/config/environment.js b/packages/changeset-form/config/environment.js
@@ -1,5 +1,5 @@
 'use strict';
 
-module.exports = function(/* environment, appConfig */) {
+module.exports = function (/* environment, appConfig */) {
   return {};
 };
diff --git a/packages/changeset-form/ember-cli-build.js b/packages/changeset-form/ember-cli-build.js
@@ -3,7 +3,7 @@
 const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
 const path = require('path');
 
-module.exports = function(defaults) {
+module.exports = function (defaults) {
   const app = new EmberAddon(defaults, {
     postcssOptions: {
       compile: {

diff --git a/packages/changeset-form/tests/dummy/app/components/changeset-form-example.ts b/packages/changeset-form/tests/dummy/app/components/changeset-form-example.ts
@@ -14,7 +14,7 @@ interface ExampleArgs {}
 
 export default class Example extends Component<ExampleArgs> {
   validations = myValidations;
-  countries = countries.map(c => c.name);
+  countries = countries.map((c) => c.name);
 
   model = {
     firstName: null,

diff --git a/packages/changeset-form/tests/dummy/app/router.js b/packages/changeset-form/tests/dummy/app/router.js
@@ -6,6 +6,6 @@ export default class Router extends EmberRouter {
   rootURL = config.rootURL;
 }
 
-Router.map(function() {
+Router.map(function () {
   // there are no routes in this dummy app
 });
diff --git a/packages/changeset-form/tests/dummy/config/environment.js b/packages/changeset-form/tests/dummy/config/environment.js
@@ -1,6 +1,6 @@
 'use strict';
 
-module.exports = function(environment) {
+module.exports = function (environment) {
   const ENV = {
     modulePrefix: 'dummy',
     environment,

diff --git a/packages/changeset-form/tests/integration/components/changeset-form-test.ts b/packages/changeset-form/tests/integration/components/changeset-form-test.ts
@@ -5,7 +5,7 @@ import hbs from 'htmlbars-inline-precompile';
 import validateFormat from 'ember-changeset-validations/validators/format';
 import validatePresence from 'ember-changeset-validations/validators/presence';
 
-module('Integration | Component | ChangesetForm', function(hooks) {
+module('Integration | Component | ChangesetForm', function (hooks) {
   setupRenderingTest(hooks);
 
   hooks.beforeEach(async function beforeEach(this: { set: Function }) {
@@ -14,7 +14,7 @@ module('Integration | Component | ChangesetForm', function(hooks) {
         first: 'Chim',
         last: 'Richolds'
       },
-      email: 'chim.richolds@neighborly.com'
+      email: 'chim.richolds@example.com'
     };
     const validations = {
       'name.first': validatePresence(true),
@@ -60,7 +60,7 @@ module('Integration | Component | ChangesetForm', function(hooks) {
     `);
   });
 
-  test('it renders with initial value from model', async function(assert) {
+  test('it renders with initial value from model', async function (assert) {
     assert
       .dom('[data-test-changeset-form]')
       .exists('The ChangesetForm failed to render');
@@ -76,7 +76,7 @@ module('Integration | Component | ChangesetForm', function(hooks) {
     assert.dom('[data-test-email-input]').hasValue(this.get('model.email'));
   });
 
-  test('it validates and then updates the changeset on input', async function(assert) {
+  test('it validates and then updates the changeset on input', async function (assert) {
     await fillIn('[data-test-email-input]', 'notanemailaddress');
     await blur('[data-test-email-input]');
 
@@ -87,7 +87,7 @@ module('Integration | Component | ChangesetForm', function(hooks) {
     assert.dom('[data-test-email]').hasTextContaining('notanemailaddress');
   });
 
-  test('it rolls-back the changeset, and calls onReset when reset is clicked', async function(assert) {
+  test('it rolls-back the changeset, and calls onReset when reset is clicked', async function (assert) {
     assert.expect(7);
     await fillIn('[data-test-name-first-input]', 'James');
     await fillIn('[data-test-name-last-input]', 'Silva');
@@ -105,12 +105,10 @@ module('Integration | Component | ChangesetForm', function(hooks) {
 
     assert.dom('[data-test-name-first-input]').hasValue('Chim');
     assert.dom('[data-test-name-last-input]').hasValue('Richolds');
-    assert
-      .dom('[data-test-email-input]')
-      .hasValue('chim.richolds@neighborly.com');
+    assert.dom('[data-test-email-input]').hasValue('chim.richolds@example.com');
   });
 
-  test('it calls onSubmit when the submit button is clicked and marks hasSubmitted to true', async function(assert) {
+  test('it calls onSubmit when the submit button is clicked and marks hasSubmitted to true', async function (assert) {
     assert.expect(8);
     await fillIn('[data-test-name-first-input]', 'James');
     await fillIn('[data-test-name-last-input]', 'Silva');

diff --git a/.../changeset-form/tests/integration/components/changeset-form/fields/checkbox-group-test.ts b/.../changeset-form/tests/integration/components/changeset-form/fields/checkbox-group-test.ts
@@ -7,7 +7,7 @@ import { run } from '@ember/runloop';
 
 module(
   'Integration | Component | ChangesetForm::Fields::CheckboxGroup',
-  function(hooks) {
+  function (hooks) {
     setupRenderingTest(hooks);
 
     hooks.beforeEach(async function beforeEach(this: { set: Function }) {
@@ -46,13 +46,13 @@ module(
       `);
     });
 
-    test('it renders with initial model value', async function(assert) {
+    test('it renders with initial model value', async function (assert) {
       assert.dom('[data-test-checkbox-blue]').isChecked();
       assert.dom('[data-test-checkbox-green]').isNotChecked();
       assert.dom('[data-test-checkbox-red]').isNotChecked();
     });
 
-    test('it updates the changeset on input', async function(assert) {
+    test('it updates the changeset on input', async function (assert) {
       await click('[data-test-checkbox-blue]');
       await click('[data-test-checkbox-green]');
       await click('[data-test-checkbox-red]');
@@ -62,7 +62,7 @@ module(
       assert.equal(this.get('changeset').get('colors.red'), true);
     });
 
-    test('it receives original input values on rollback', async function(assert) {
+    test('it receives original input values on rollback', async function (assert) {
       await click('[data-test-checkbox-green]');
 
       assert.dom('[data-test-checkbox-blue]').isChecked();