Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Overlays + Power Select #149

Merged
merged 2 commits into from
Feb 24, 2021
Merged

doc: Overlays + Power Select #149

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d9423e
doc: Overlays + Power Select
MichalBryxi Feb 19, 2021
8a56f5e
Update packages/overlays/addon/components/overlay.md
MichalBryxi Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/overlays/addon/components/overlay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ It contains all the core features necessary for a great experience.

> Important: You must have a focusable element inside of the Overlay.

## Note on Overlays and other portal elements

`FormSelect` uses Power Select under the hood and has `@renderInPlace={{false}}` set by default, which will insert the content of the drop-down outside of the `Overlay` (or `Drawer` or `Modal`) and because of that focus-trap will prevent accessing focusable elements ([search input](https://ember-power-select.com/docs/the-search)) in said Power Select. To solve this you have following options:

- `<Overlay @disableFocusTrap={{true}} />` (not recommended)
- `<FormSelect @renderInPlace={{false}} />` (recommended)
MichalBryxi marked this conversation as resolved.
Show resolved Hide resolved

## API

<ArgsTable @of="Overlay" />