Mark radio and checkbox container elements as checked to allow label styling #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the inner children for max flexibility
jkeen
changed the title
|
@josemarluedke Josemar! I've slowly been migrating my some old custom components to using frontile, and even without being a tailwind guy this component set is saving me so much time and headache. Thanks for all your work on this beautiful library |
|
The changes look good. Thanks for working on them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with the
<input>element inside a wrapper element, you can't style the form labels differently based on the checked state of the input (which I'd normally do with ainput:checked + labelselector)This PR adds a
--checkedvariant class to the top-level form elements of both the radio buttons and checkboxes when they're checked so that the child elements can be targeted and styled