A little bit of cleanup. Including removing the Vert dimension.

joseph · Feb 9, 2012 · 1b5c86f · 1b5c86f
1 parent 83cf064
commit 1b5c86f
Show file tree

Hide file tree

Showing 30 changed files with 21 additions and 136 deletions.
diff --git a/src/compat/browser.js b/src/compat/browser.js
@@ -1,4 +1,4 @@
-Monocle.Browser = {}
+Monocle.Browser = {};
 
 // Compare the user-agent string to a string or regex pattern.
 //
@@ -20,6 +20,8 @@ Monocle.Browser.is = {
 }
 
 
+// Set the browser engine string.
+//
 if (Monocle.Browser.is.IE) {
   Monocle.Browser.engine = "IE";
 } else if (Monocle.Browser.is.Opera) {
@@ -29,6 +31,7 @@ if (Monocle.Browser.is.IE) {
 } else if (Monocle.Browser.is.Gecko) {
   Monocle.Browser.engine = "Gecko";
 } else {
+  console.warn("Unknown engine; assuming W3C compliant.");
   Monocle.Browser.engine = "W3C";
 }
 

diff --git a/src/compat/css.js b/src/compat/css.js
@@ -1,3 +1,5 @@
+// A class for manipulating CSS properties in a browser-engine-aware way.
+//
 Monocle.CSS = function () {
 
   var API = { constructor: Monocle.CSS }

diff --git a/src/compat/env.js b/src/compat/env.js
@@ -1,3 +1,6 @@
+// A class that tests the browser environment for required capabilities and
+// known bugs (for which we have workarounds).
+//
 Monocle.Env = function () {
 
   var API = { constructor: Monocle.Env }

diff --git a/src/compat/stubs.js b/src/compat/stubs.js
@@ -27,3 +27,12 @@ window.console.compatDir = function (obj) {
 
   window.console.log(stringify(obj));
 }
+
+
+// A convenient alias for setTimeout that assumes 0 if no timeout is specified.
+//
+Monocle.defer = function (fn, time) {
+  if (fn && typeof fn == "function") {
+    return setTimeout(fn, time || 0);
+  }
+}
diff --git a/src/controls/contents.js b/src/controls/contents.js
@@ -1,7 +1,4 @@
 Monocle.Controls.Contents = function (reader) {
-  if (Monocle.Controls == this) {
-    return new Monocle.Controls.Contents(reader);
-  }
 
   var API = { constructor: Monocle.Controls.Contents }
   var k = API.constants = API.constructor;

diff --git a/src/controls/magnifier.js b/src/controls/magnifier.js
@@ -1,9 +1,5 @@
 Monocle.Controls.Magnifier = function (reader) {
-  if (Monocle.Controls == this) {
-    return new Monocle.Controls.Magnifier(reader);
-  }
 
-  // Public methods and properties.
   var API = { constructor: Monocle.Controls.Magnifier }
   var k = API.constants = API.constructor;
   var p = API.properties = {

diff --git a/src/controls/placesaver.js b/src/controls/placesaver.js
@@ -1,7 +1,4 @@
 Monocle.Controls.PlaceSaver = function (bookId) {
-  if (Monocle.Controls == this) {
-    return new Monocle.Controls.PlaceSaver(bookId);
-  }
 
   var API = { constructor: Monocle.Controls.PlaceSaver }
   var k = API.constants = API.constructor;

diff --git a/src/controls/scrubber.js b/src/controls/scrubber.js
@@ -1,7 +1,4 @@
 Monocle.Controls.Scrubber = function (reader) {
-  if (Monocle.Controls == this) {
-    return new Monocle.Controls.Scrubber(reader);
-  }
 
   var API = { constructor: Monocle.Controls.Scrubber }
   var k = API.constants = API.constructor;

diff --git a/src/controls/spinner.js b/src/controls/spinner.js
@@ -1,7 +1,4 @@
 Monocle.Controls.Spinner = function (reader) {
-  if (Monocle.Controls == this) {
-    return new Monocle.Controls.Spinner(reader);
-  }
 
   var API = { constructor: Monocle.Controls.Spinner }
   var k = API.constants = API.constructor;

diff --git a/src/controls/stencil.js b/src/controls/stencil.js
@@ -1,7 +1,5 @@
 Monocle.Controls.Stencil = function (reader) {
 
-  if (Monocle.Controls == this) { return new this.Stencil(reader); }
-
   var API = { constructor: Monocle.Controls.Stencil }
   var k = API.constants = API.constructor;
   var p = API.properties = {

diff --git a/src/core/book.js b/src/core/book.js
@@ -10,7 +10,6 @@
  *
  */
 Monocle.Book = function (dataSource) {
-  if (Monocle == this) { return new Monocle.Book(dataSource); }
 
   var API = { constructor: Monocle.Book }
   var k = API.constants = API.constructor;

diff --git a/src/core/events.js b/src/core/events.js
@@ -1,4 +1,4 @@
-Monocle.Events = {}
+Monocle.Events = {};
 
 
 // Fire a custom event on a given target element. The attached data object will

diff --git a/src/core/monocle.js b/src/core/monocle.js
@@ -10,14 +10,7 @@ Monocle = {
 };
 
 
-Monocle.defer = function (fn, time) {
+Monocle.Dimensions = {};
-  if (fn && typeof fn == "function") {
-    return setTimeout(fn, time || 0);
-  }
-}
-
-
-Monocle.Dimensions = {}
 Monocle.Controls = {};
 Monocle.Flippers = {};
 Monocle.Panels = {};
diff --git a/src/core/reader.js b/src/core/reader.js
@@ -31,9 +31,6 @@
 //  systemId: the id for root elements of components, defaults to "RS:monocle"
 //
 Monocle.Reader = function (node, bookData, options, onLoadCallback) {
-  if (Monocle == this) {
-    return new Monocle.Reader(node, bookData, options, onLoadCallback);
-  }
 
   var API = { constructor: Monocle.Reader }
   var k = API.constants = API.constructor;

diff --git a/src/core/styles.js b/src/core/styles.js
@@ -95,6 +95,7 @@ Monocle.Styles = {
 //
 Monocle.Styles.container = {
   "position": "absolute",
+  "overflow": "hidden",
   "top": "0",
   "left": "0",
   "bottom": "0",

diff --git a/src/dimensions/vert.js b/src/dimensions/vert.js
diff --git a/src/flippers/slider.js b/src/flippers/slider.js
@@ -1,7 +1,4 @@
 Monocle.Flippers.Slider = function (reader) {
-  if (Monocle.Flippers == this) {
-    return new Monocle.Flippers.Slider(reader);
-  }
 
   var API = { constructor: Monocle.Flippers.Slider }
   var k = API.constants = API.constructor;

diff --git a/test/bookdata/index.html b/test/bookdata/index.html
@@ -21,7 +21,6 @@
         height: 400px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
       #part1, #part2 {
         display: none;

diff --git a/test/componentry/index.html b/test/componentry/index.html
@@ -18,7 +18,6 @@
         height: 400px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
 
       #hiddenFrames {

diff --git a/test/controls/index.html b/test/controls/index.html
@@ -19,7 +19,6 @@
         height: 400px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
       #part1, #part2 {
         display: none;

diff --git a/test/dogfood/index.html b/test/dogfood/index.html
@@ -13,9 +13,7 @@
         height: 400px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
         margin: 2em 0;
-        float: left;
       }
       #theCode {
         clear: both;

diff --git a/test/dogfood/simplest.html b/test/dogfood/simplest.html
@@ -18,7 +18,6 @@
         width: 300px;
         height: 400px;
         border: 1px solid #000;
-        overflow: hidden;
       }
     </style>
 

diff --git a/test/events/index.html b/test/events/index.html
@@ -13,7 +13,6 @@
         height: 400px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
       #out {
         font: 9pt Consolas, Inconsolata, Menlo, Andale Mono, Monaco, monospace;

diff --git a/test/flippers/index.html b/test/flippers/index.html
@@ -18,7 +18,6 @@
         height: 400px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
       #part1, #part2 {
         display: none;

diff --git a/test/locus-search/index.html b/test/locus-search/index.html
@@ -13,7 +13,6 @@
         height: 400px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
     </style>
 

diff --git a/test/panels/index.html b/test/panels/index.html
@@ -18,7 +18,6 @@
         height: 400px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
       #part1, #part2 {
         display: none;

diff --git a/test/rich_content/index.html b/test/rich_content/index.html
@@ -17,7 +17,6 @@
         height: 420px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
     </style>
 

diff --git a/test/showcase/01-velveteen/index.html b/test/showcase/01-velveteen/index.html
@@ -17,7 +17,6 @@
         height: 420px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
     </style>
 

diff --git a/test/stencil/index.html b/test/stencil/index.html
@@ -23,7 +23,6 @@
         height: 400px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
     </style>
 

diff --git a/test/stylesheet/index.html b/test/stylesheet/index.html
@@ -17,7 +17,6 @@
         height: 420px;
         border: 1px solid #000;
         background-color: #CCC;
-        overflow: hidden;
       }
     </style>