Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination for Chrome 22+ when zooming #146

Closed
wants to merge 3 commits into from

Conversation

nono
Copy link

@nono nono commented Oct 14, 2012

Hi,

when using Monocle on Chrome 22+ (with sub-pixel rendering) and zooming (in or out), the pages can be cut on the left or right when we advance far in a component.This commit can be the start of a fix for this issue.

@joseph
Copy link
Owner

joseph commented Oct 17, 2012

pageDimensions gets called quite a lot. Adding stuff to the DOM, styling it and removing it each time is a bit nasty. Can we look at being kinder on the DOM? If it only affects WebKit, perhaps we should fence it in a WebKit-only conditional too?

@nono
Copy link
Author

nono commented Oct 20, 2012

Can we look at being kinder on the DOM?

Yes, do you have any idea about that? Computing this value only one time and hoping the user won't change his zoom level after that?

If it only affects WebKit, perhaps we should fence it in a WebKit-only conditional too?

Yes, I didn't look at src/compat/env.js and thought that Monocle.Browser.env.roundPageDimensions was only for WebKit. But it's not the case, so I should modify that.

@nono
Copy link
Author

nono commented Oct 21, 2012

By the way, zooming on firefox 16 works better when I don't do the rounding.

@eunomie
Copy link

eunomie commented Nov 28, 2012

What about using the resize event to compute the zoom level only when changed ?

@joseph
Copy link
Owner

joseph commented May 10, 2013

Closed because see comments on #161. Thanks.

@joseph joseph closed this May 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants