Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test folder - controls/Index.html doesn't pay attention to internal styles #18

Closed
mslatter opened this issue Dec 27, 2010 · 1 comment
Closed

Comments

@mslatter
Copy link

In the test folder, under the "controls" test, it appears to me that the internal styles that apply to the class "reader" are ignored. For instance, there's an attempt to center the h3 tag, but it clearly isn't applied to the displayed text in the reader.

I toyed a bit and figured that to get it to work, I'd have to set the styleSheet attribute while initializing the reader. In this case, that's done via a variable that's already used to set the panels:

    function () {
      var readerOptions = {
        panels: Monocle.Panels.Marginal,
    stylesheet: "h3 {text-align: center; }"
      };

(I added the "stylesheet" variable)

Perhaps not a bug in the Monocle reader itself, but a misleading test case.

@joseph
Copy link
Owner

joseph commented Dec 30, 2010

Oh yeah, that's some really old CSS — not applicable since the switch to iframes. Thanks, I'll nuke it.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants