Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add improved e notation #18

Merged
merged 2 commits into from
Mar 26, 2023
Merged

add improved e notation #18

merged 2 commits into from
Mar 26, 2023

Conversation

dbatten5
Copy link
Contributor

@dbatten5 dbatten5 commented Mar 26, 2023

closes #15

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 26, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.31%.

Quality metrics Before After Change
Complexity 21.02 😞 20.90 😞 -0.12 👍
Method Length 152.50 😞 154.17 😞 1.67 👎
Working memory 11.92 😞 11.87 😞 -0.05 👍
Quality 37.50% 😞 37.81% 😞 0.31% 👍
Other metrics Before After Change
Lines 385 387 2
Changed files Quality Before Quality After Quality Change
array_to_latex/__init__.py 37.50% 😞 37.81% 😞 0.31% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
array_to_latex/__init__.py _dataframetolatex 31 😞 354 ⛔ 13 😞 22.25% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
array_to_latex/__init__.py _numpyarraytolatex 23 😞 327 ⛔ 13 😞 27.29% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
array_to_latex/__init__.py to_ltx 8 ⭐ 116 🙂 14 😞 52.42% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@josephcslater josephcslater merged commit d7e7bd3 into josephcslater:master Mar 26, 2023
@josephcslater
Copy link
Owner

Release 0.91 is out. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the output of the scientific "e" notation
2 participants