Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

Ignore "unset" values #5

Merged
merged 3 commits into from
Nov 9, 2018
Merged

Ignore "unset" values #5

merged 3 commits into from
Nov 9, 2018

Conversation

duailibe
Copy link
Contributor

@duailibe duailibe commented Nov 6, 2018

This PR adds support for ignoring "unset" values.

See prettier/prettier#5351

Copy link
Owner

@josephfrazier josephfrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one thing needs to change, but LGTM otherwise!

test.js Outdated
tabWidth: 4,
useTabs: true
useTabs: false,
tabWidth: 2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this a new test, instead of changing an existing test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not sure what happened here, that was not my intention

@kachkaev
Copy link
Contributor

kachkaev commented Nov 8, 2018

@josephfrazier it'd be great if you could release 1.0.1 in a couple of days so that it could be included into Prettier 1.15.2: https://github.com/prettier/prettier/milestone/24.

test.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
@josephfrazier josephfrazier merged commit 2c0851f into josephfrazier:master Nov 9, 2018
@josephfrazier
Copy link
Owner

Just published v0.1.1, thanks folks!

@duailibe duailibe deleted the ignore-unset branch November 10, 2018 01:11
@duailibe
Copy link
Contributor Author

Thank you @josephfrazier !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants