-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one thing needs to change, but LGTM otherwise!
test.js
Outdated
tabWidth: 4, | ||
useTabs: true | ||
useTabs: false, | ||
tabWidth: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this a new test, instead of changing an existing test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not sure what happened here, that was not my intention
@josephfrazier it'd be great if you could release 1.0.1 in a couple of days so that it could be included into Prettier 1.15.2: https://github.com/prettier/prettier/milestone/24. |
Just published |
Thank you @josephfrazier ! |
This PR adds support for ignoring
"unset"
values.See prettier/prettier#5351