Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install outdated browser bundle in /dist folder (Windows) #378

Closed
Thylossus opened this issue Jun 3, 2015 · 6 comments
Closed

npm install outdated browser bundle in /dist folder (Windows) #378

Thylossus opened this issue Jun 3, 2015 · 6 comments

Comments

@Thylossus
Copy link

Hi,

While I was trying to resolve an issue in my ShareJS application, I found that the browser bundle in the the ShareJS module's /dist folder is not up-to-date. I hat to run browserify myself to create a bundle based on the newest version (0.7.37).

I assume this problem is caused by Windows not supporting make. However, npm install displays neither a warning nor an error message.

For me this was quite a problem because the doc's _sendOpData function did not assign a sequence number to my operations.

@pedrosanta
Copy link
Contributor

Yep, it seems to be outdated, yes. I've also had issues on #382.

Perhaps @nateps or @josephg could rebuild the lib and republish the package?

@pedrosanta
Copy link
Contributor

Don't know if @jhchen could also do it...

@pedrosanta
Copy link
Contributor

It seems that even on the last version 0.7.39 the dist lib is still outdated, still throwing errors. (Refer to #382)

@josephg
Copy link
Owner

josephg commented Jul 31, 2015

Ugh. Its because of this change from @dignifiedquire: 43004c5

The change rewrote the makefile, removing the webclient target for make. The package.json still tries to build the webclient target in a prepublish step, and thats not happening anymore.

@josephg
Copy link
Owner

josephg commented Jul 31, 2015

I fixed the problem and published 0.7.40. Please confirm & reopen the issue if its still a problem.

@pedrosanta
Copy link
Contributor

@josephg Works great! Awesome. 👍 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants