Share minified code only in production

[esamattis]

ShareJS should serve minified code only when NODE_ENV=production is set.

Or if there is a way to disable it, it should be documented better :)

I had today hard time debugging it.

[josephg]

ShareJS will serve the uncompressed version of the JS as well. While debugging, I just change my script reference to

<script src="share/share.uncompressed.js"></script>

Is NODE_ENV pretty standard now? You're right - that might be a better idea.

[esamattis]

Well at least Express uses it and it's pretty de facto :)

But anyways consider this as documentation issue. I think by default we should point people to use the uncompressed one. Minified one comes to table only when the app is really in production. Before that we should make everything clear as possible for the developers.

Maybe share/share.jsshould serve the uncompressed one and share/share.min.js the minified one?

[josephg]

Yeah fair enough. For now lets make the documentation by default point to share.uncompressed.js, and mention the minified version.

Mind if I assign this to you, @epeli ?

[esamattis]

Well, sure, go ahead and assign :)

[CrypticSwarm]

Examples now use unminified version. Can this issue be closed?

[esamattis]

Oh, I totally forgot this. Yes, thank you!