Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are not run on compiled client #11

Closed
josephg opened this issue May 16, 2011 · 1 comment
Closed

Tests are not run on compiled client #11

josephg opened this issue May 16, 2011 · 1 comment

Comments

@josephg
Copy link
Owner

josephg commented May 16, 2011

Currently, the nodeunit tests aren't run on the closure compiled client code. There's a bunch of ways closure can break the client - and without tests, there's no confidence that it works.

The compiled share.js file should be wrapped in a nodejs module or something and the client tests should be run on it.
@josephg
Copy link
Owner Author

josephg commented Aug 14, 2011

Fixed in 0.3.0

@josephg josephg closed this as completed Aug 14, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephg