add double BP to recurrent_example

josephjaspers · Aug 3, 2019 · 2377260 · 2377260
1 parent 306872c
commit 2377260
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/examples/mnist_test_recurrent/mnist_test.h b/examples/mnist_test_recurrent/mnist_test.h
@@ -87,6 +87,8 @@ int percept_MNIST(System system_tag, const char* mnist_dataset,
 
 				//Truncate BP to only the last output
 				network.back_propagation(outputs[j]);
+				network.back_propagation(outputs[j]);
+
 				network.update_weights();
 		}
 	}

diff --git a/examples/mnist_test_recurrent/mnist_test_exec b/examples/mnist_test_recurrent/mnist_test_exec
diff --git a/include/neural_networks/Layer_Chain.h b/include/neural_networks/Layer_Chain.h
@@ -14,9 +14,11 @@ namespace detail {
 	template<bool Recurrent, int Index, class Derived, class Layer>
 	using LayerManager =
 			std::conditional_t<Recurrent,
-				std::conditional_t<Index == 0,
-					Input_Layer_Manager<Derived, Layer>, //if first layer
-					Recurrent_Layer_Manager<Derived, Layer>>,
+
+//TODO Add recurrent input layer_manager
+//				std::conditional_t<Index == 0,
+//					Input_Layer_Manager<Derived, Layer>, //if first layer
+					Recurrent_Layer_Manager<Derived, Layer>, //>,
 				std::conditional_t<Index == 0,
 					Input_Layer_Manager<Derived, Layer>, //if first layer
 					Layer_Manager<Derived, Layer>>>;

diff --git a/include/neural_networks/Layers/Recurrent.h b/include/neural_networks/Layers/Recurrent.h
@@ -28,7 +28,7 @@ struct Recurrent : public Layer_Base {
 
 private:
 
-    ValueType lr = 0.03;
+    ValueType lr = 0.0003;
 
     mat w;  //weights
     mat r;