Use Dir.glob instead of git ls-files

[utkarsh2102]

Hi,

This drops the unnecessary dependency of git.
I've been maintaining this in Debian and while building this, adding git as a dependency is useless if we can do the same thing with Dir.glob 🚀

[nextmat]

Hmm, this isn't actually equivalent since it will include files ignored by git. How about this?

require 'rake/file_list'
Rake::FileList['**/*'].exclude(*File.read('.gitignore').split)

[nextmat]

Thanks!

[utkarsh2102]

Hi @nextmat,

Hmm, this isn't actually equivalent since it will include files ignored by git. How about this?

require 'rake/file_list'
Rake::FileList['**/*'].exclude(*File.read('.gitignore').split)

Just wondering, how'd you do this if .gitignore had patterns and not files listed explicitly?

[nextmat]

@utkarsh2102 I believe FileList.exclude accepts a list of patterns, so it should work okay.

[utkarsh2102]

@utkarsh2102 I believe FileList.exclude accepts a list of patterns, so it should work okay.

Oh no, I hit an obstacle when I was trying to use ! in the gitignore file :/
I opened this issue here: ruby/rake#356

[nextmat]

Oh no, I hit an obstacle when I was trying to use ! in the gitignore file :/
I opened this issue here: ruby/rake#356

Interesting, good to know!