Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor with Dredd and better practices around separating DB from JSON output. #16

Merged
merged 12 commits into from
Jul 9, 2018
Merged

Refactor with Dredd and better practices around separating DB from JSON output. #16

merged 12 commits into from
Jul 9, 2018

Conversation

josephspurrier
Copy link
Owner

No description provided.

@josephspurrier
Copy link
Owner Author

Closes #13

@josephspurrier
Copy link
Owner Author

Closes #12

@josephspurrier josephspurrier merged commit a6a6ba4 into master Jul 9, 2018
@josephspurrier josephspurrier deleted the dredd branch July 9, 2018 03:00
@coveralls
Copy link

coveralls commented Jul 9, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 50

  • 15 of 128 (11.72%) changed or added relevant lines in 13 files are covered.
  • 527 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-9.3%) to 76.581%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/webapi/component/user/update.go 0 1 0.0%
src/app/webapi/component/user/destroy_all.go 0 1 0.0%
src/app/webapi/middleware/middleware.go 0 2 0.0%
src/app/webapi/middleware/jwt/jwt.go 0 2 0.0%
src/app/webapi/component/user/destroy.go 0 2 0.0%
src/app/webapi/webapi.go 8 12 66.67%
src/app/webapi/internal/response/response.go 2 13 15.38%
src/app/webapi/component/user/index.go 1 12 8.33%
src/app/webapi/pkg/logger/logger.go 0 12 0.0%
src/app/webapi/component/user/show.go 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
src/app/webapi/component/user/index.go 1 90.91%
src/app/webapi/pkg/router/router.go 3 100.0%
src/app/webapi/internal/testutil/mock_token.go 4 50.0%
src/app/webapi/pkg/router/handler.go 5 54.55%
src/app/webapi/pkg/router/helper.go 9 100.0%
src/app/webapi/pkg/logger/logger.go 9 100.0%
src/app/webapi/pkg/database/database.go 9 100.0%
src/app/webapi/internal/response/response.go 9 84.21%
src/app/webapi/component/user/destroy_all.go 10 91.67%
src/app/webapi/pkg/securegen/securegen.go 10 83.33%
Totals Coverage Status
Change from base Build 37: -9.3%
Covered Lines: 896
Relevant Lines: 1170
💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 50

  • 15 of 128 (11.72%) changed or added relevant lines in 13 files are covered.
  • 527 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-9.3%) to 76.581%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/webapi/component/user/update.go 0 1 0.0%
src/app/webapi/component/user/destroy_all.go 0 1 0.0%
src/app/webapi/middleware/middleware.go 0 2 0.0%
src/app/webapi/middleware/jwt/jwt.go 0 2 0.0%
src/app/webapi/component/user/destroy.go 0 2 0.0%
src/app/webapi/webapi.go 8 12 66.67%
src/app/webapi/internal/response/response.go 2 13 15.38%
src/app/webapi/component/user/index.go 1 12 8.33%
src/app/webapi/pkg/logger/logger.go 0 12 0.0%
src/app/webapi/component/user/show.go 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
src/app/webapi/component/user/index.go 1 90.91%
src/app/webapi/pkg/router/router.go 3 100.0%
src/app/webapi/internal/testutil/mock_token.go 4 50.0%
src/app/webapi/pkg/router/handler.go 5 54.55%
src/app/webapi/pkg/router/helper.go 9 100.0%
src/app/webapi/pkg/logger/logger.go 9 100.0%
src/app/webapi/pkg/database/database.go 9 100.0%
src/app/webapi/internal/response/response.go 9 84.21%
src/app/webapi/component/user/destroy_all.go 10 91.67%
src/app/webapi/pkg/securegen/securegen.go 10 83.33%
Totals Coverage Status
Change from base Build 37: -9.3%
Covered Lines: 896
Relevant Lines: 1170
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 50

  • 15 of 128 (11.72%) changed or added relevant lines in 13 files are covered.
  • 527 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-9.3%) to 76.581%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/webapi/component/user/update.go 0 1 0.0%
src/app/webapi/component/user/destroy_all.go 0 1 0.0%
src/app/webapi/middleware/middleware.go 0 2 0.0%
src/app/webapi/middleware/jwt/jwt.go 0 2 0.0%
src/app/webapi/component/user/destroy.go 0 2 0.0%
src/app/webapi/webapi.go 8 12 66.67%
src/app/webapi/internal/response/response.go 2 13 15.38%
src/app/webapi/component/user/index.go 1 12 8.33%
src/app/webapi/pkg/logger/logger.go 0 12 0.0%
src/app/webapi/component/user/show.go 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
src/app/webapi/component/user/index.go 1 90.91%
src/app/webapi/pkg/router/router.go 3 100.0%
src/app/webapi/internal/testutil/mock_token.go 4 50.0%
src/app/webapi/pkg/router/handler.go 5 54.55%
src/app/webapi/pkg/router/helper.go 9 100.0%
src/app/webapi/pkg/logger/logger.go 9 100.0%
src/app/webapi/pkg/database/database.go 9 100.0%
src/app/webapi/internal/response/response.go 9 84.21%
src/app/webapi/component/user/destroy_all.go 10 91.67%
src/app/webapi/pkg/securegen/securegen.go 10 83.33%
Totals Coverage Status
Change from base Build 37: -9.3%
Covered Lines: 896
Relevant Lines: 1170
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josephspurrier @coveralls