-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Default LogLabel provider with PropertiesAsLabels option #22
Conversation
Hi @josephwoodward, Thank you for your project! |
We are also looking forward to this :) |
Hi @Falco20019 You can use this now
|
@Falco20019 Interested to see what you come up with. I've been slowly working through #15 but as it's quite a large PR there's a lot changing in there and I need to get back up to speed. I like this PR because it's smaller and doesn't change so much of the behaviour, but like you said, #15 is more flexible. |
I'm also thinking PropertiesAsLabels should be false by default to prevent an accidental explosion of labels which could prove an issue with high throughout systems. Instead you should have to explicitly opt in to the property being turned into a label so that such a change is visible in a PR instead of being unaware of it happening. |
Not sure if I would merge #15 and #22. Since #15 is introducing a flag for the strategy, this behavior can already be defined there. I think it might be still useful to be able to do it from the provider too, but it would need to be rebased once #15 is in since they both target the same area and would lead to conflicts. |
I've done some refactoring and introduced |
No description provided.