Remove rune v3 #36
Remove rune v3 #36
Conversation
Feels good to delete old code Feels bad for delay
There's still much more to update Hope to finish soon
how does this even happen reset head force push
Keystones have taken over I guess less is more
| let (:url2) {expand_template(Taric::Operation::LolStaticData::STATIC_VERSIONS.template_url)} | ||
| before {stub_get_json(url2, 'static_versions.json')} | ||
| let (:url2) {expand_template(Taric::Operation::Champion::CHAMPIONS.template_url, region: 'na')} | ||
| before {stub_get(url2).to_return(body: fixture('champions.json'), headers: {content_type: 'application/json; charset=utf-8'})} |
There was a problem hiding this comment.
Layout/SpaceInsideBlockBraces: Space missing inside {.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Metrics/LineLength: Line is too long. [132/80]
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideBlockBraces: Space missing inside }.
| @@ -41,27 +41,27 @@ | |||
| describe '#execute!' do | |||
| let (:url) {expand_template(Taric::Operation::LolStatus::SHARD.template_url, region: 'na')} | |||
| before {stub_get(url).to_return(body: fixture('shard.json'), headers: {content_type: 'application/json; charset=utf-8'})} | |||
| let (:url2) {expand_template(Taric::Operation::LolStaticData::STATIC_VERSIONS.template_url)} | |||
| before {stub_get_json(url2, 'static_versions.json')} | |||
| let (:url2) {expand_template(Taric::Operation::Champion::CHAMPIONS.template_url, region: 'na')} | |||
There was a problem hiding this comment.
Lint/ParenthesesAsGroupedExpression: (...) interpreted as grouped expression.
Layout/SpaceInsideBlockBraces: Space missing inside {.
Metrics/LineLength: Line is too long. [101/80]
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Layout/SpaceInsideBlockBraces: Space missing inside }.
| @@ -1,3 +1,3 @@ | |||
| module Taric | |||
| VERSION = '1.0.0' | |||
| VERSION = '2.0.0-alpha' | |||
There was a problem hiding this comment.
Style/MutableConstant: Freeze mutable objects assigned to constants.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
2 similar comments
No description provided.