Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching windows while opening tabs causes some (rest?) to open in new window #28

Closed
junkblocker opened this issue Jul 17, 2019 · 2 comments
Closed

Switching windows while opening tabs causes some (rest?) to open in new window #28

junkblocker opened this issue Jul 17, 2019 · 2 comments
Assignees
@josh-berry
Labels
i-bug Something is likely broken in Tab Stash

Comments

@junkblocker
Copy link

Describe the bug
If I open a stash with a few hundred tabs and switch browser windows while the tabs are being opened, some of the tabs get opened in the newly focused window. They should open in the original window when the open all tabs button was clicked.

To Reproduce
Detailed steps to reproduce the behavior:

  1. Have two, (preferably empty to see the problem easily) browser windows available.
  2. Have a stash with a couple of hundred or so tabs.
  3. Click 'Open all tabs in this group' button in the sidebar
  4. Quickly switch to the other window while tabs are still being opened.
  5. Notice that some tabs got opened in the new window we just switched to.

Expected behavior
All tabs should open in the original window the "Open all tabs" button was clicked in.

Screenshots
.

Desktop (please complete the following information):

  • OS: Mac
  • Firefox Browser Version: 68.0

Additional context
.
@josh-berry
Copy link
Owner

Hi, thanks for the report and sorry for the inconvenience! And especially thanks for the detailed steps; they made it quite easy to reproduce the problem on my end.

I think I've figured out why this is happening. There was one place in the code where we open new tabs (if we can't find any hidden/recently-closed tabs), and we don't tell Firefox which window they're for, so Firefox just puts them in whatever window is active.

I have a fix ready to go and will include it in the next release.

@josh-berry josh-berry added the i-bug Something is likely broken in Tab Stash label Jul 18, 2019
@josh-berry josh-berry self-assigned this Jul 18, 2019
josh-berry added a commit that referenced this issue Jul 20, 2019
@josh-berry
stash: Tell Firefox which window new tabs belong to [#28]
c075b0b 
In `restoreTabs()`, we were not passing a windowId to `tabs.create()`,
so the tabs were just going into the active window.  If the user quickly
switches from one window to another while a restore is happening, the
poor, hapless newly-active window will get mobbed by a bunch of tabs
that don't belong there.
@josh-berry
Copy link
Owner

This should be fixed in (just-released) Tab Stash 2.4. Thanks again for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josh-berry josh-berry

Labels
i-bug Something is likely broken in Tab Stash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junkblocker @josh-berry