Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open&delete in tab view closes the tab itself #37

Closed
AnttiBoman opened this issue Nov 12, 2019 · 4 comments
Closed

Open&delete in tab view closes the tab itself #37

AnttiBoman opened this issue Nov 12, 2019 · 4 comments
Assignees
@josh-berry
Labels
i-enhancement New functionality

Comments

@AnttiBoman
Copy link

If I use "Show Stashed Tabs in a Tab" and click the yellow open&delete button in either a group or an individual item, the Tab Stash tab closes after the tab has (tabs have) been opened and deleted.

Expected behavior
Tab Stash tab should definitely stay open, and preferably as the active tab.

Desktop:

  • OS: Linux, Ubuntu 18.04
  • Firefox Browser Version: 70.0.1 (64-bit)
@josh-berry
Copy link
Owner

Hi, thanks for your suggestion. To get this behavior today, you can just pin the Tab Stash tab, and then it won't be closed when you un-stash something.

That said, you may not want to keep Tab Stash open as a pinned tab all the time. My own experience over time has been that sometimes I want Tab Stash to go away, and sometimes I don't—so this is something that I think is worth adding as a preference. I'll keep it in mind for a future release.

@josh-berry josh-berry added the i-enhancement New functionality label Nov 17, 2019
josh-berry added a commit that referenced this issue Jan 2, 2020
@josh-berry
Don't close the stash list when restoring a single tab [#37]
6c621a3 
I've been watching my own behavior/habits with Tab Stash over the last
little bit, and I agree with the reporter that the vast majority of the
time, merely clicking a tab shouldn't cause Tab Stash itself to close.

In all cases, we now keep Tab Stash open, and holding Cmd/Ctrl will
merely decide whether the tab is restored in the background or the
foreground.
@josh-berry
Copy link
Owner

I've changed this behavior for the next release of Tab Stash (coming very soon, barring any serious bugs). Clicking on a tab (or the yellow open/delete button) will no longer close the Tab Stash tab.

If you'd like to restore a tab in the background, you can hold Ctrl (or Cmd on a Mac) while clicking the tab, just as you would if you're trying to open a link in a new background tab.

@josh-berry josh-berry self-assigned this Jan 2, 2020
josh-berry added a commit that referenced this issue Jan 2, 2020
@josh-berry
Don't close the stash list when restoring multiple tabs [#37]
e17cd0b 
Be consistent with our new single-tab behavior.
@josh-berry
Copy link
Owner

Tab Stash 2.5 was just released with this change. Hope you like it!

@AnttiBoman
Copy link
Author

Thanks for the great work again! I'm glad we have your extension available and updated frequently!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josh-berry josh-berry

Labels
i-enhancement New functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josh-berry @AnttiBoman