chore: cleanup review #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-online
reviewed
Mar 5, 2022
| names: string[], | ||
| options: Omit<Josh.Options, 'name'> = {} | ||
| ): Instances { | ||
| public static multi<Instances extends Record<string, Josh> = Record<string, Josh>>(names: string[], options: Josh.Options = {}): Instances { | ||
| const instances: Record<string, Josh> = {}; | ||
|
|
||
| for (const [name, instance] of names.map((name) => [name, new Josh({ ...options, name })]) as [string, Josh][]) instances[name] = instance; |
There was a problem hiding this comment.
Can we add a provider test to make sure multiple josh instances doesn't fail
There was a problem hiding this comment.
So like a test in providers that just boots two with different names and makes sure the same named key with different values does return correctly
|
Also issues in the unit tests |
Yep, that's why it's in the todo to rewrite those. |
|
This PR is being closed and then being split into multiple PRs due to it's size and clutter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a workspace wide review. Many changes were made.
Changes
resolveCommonIdentifiers()function.Josh#error()andJoshProvider#error()to utilizeresolveCommonIdentifiers()Josh#isPayloadWithData()method to a separate function.Josh#getKeyPath()toJosh#resolveKeyPath()Josh#getPath()toJosh#resolvePath()Josh#resolveIdentifier()JoshProviderto help ensure all providers behave the same.Josh.CommonIdentifiersenum to a separate file.Valuegeneric type fromPayloads.SetManysince this only added issues when actually using the method forcing all values to be the same.pathproperty fromPayloads.UpdateMapProviderMapProvidertestsJosh