Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Josh#each() method #60

Merged
merged 13 commits into from
Apr 20, 2022
Merged

feat: add Josh#each() method #60

merged 13 commits into from
Apr 20, 2022

Conversation

thetayloredman
Copy link
Contributor

This is my first take at adding Josh#each(). Providers will need to be changed.

@thetayloredman thetayloredman mentioned this pull request Apr 11, 2022
Closed
10 tasks
RealShadowNova
RealShadowNova requested changes Apr 11, 2022
View reviewed changes
Copy link
Member

@RealShadowNova RealShadowNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just some type changes for hook. Tests need to be implemented as well.

src/lib/structures/Josh.ts Outdated Show resolved Hide resolved
src/lib/types/Payloads.ts Outdated Show resolved Hide resolved
RealShadowNova
RealShadowNova requested changes Apr 11, 2022
View reviewed changes
Copy link
Member

@RealShadowNova RealShadowNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like what you did with the tests to check how many times the function was called 👍🏻

src/lib/structures/default-provider/MapProvider.ts Outdated Show resolved Hide resolved
src/lib/types/Payload.ts Outdated Show resolved Hide resolved
thetayloredman and others added 4 commits April 11, 2022 13:08
@thetayloredman @RealShadowNova
use ! instead of as StoredValue
879c48f 
Co-authored-by: Hezekiah Hendry <46537907+RealShadowNova@users.noreply.github.com>
@thetayloredman
some changes to tests
1939da3
@thetayloredman @RealShadowNova
add newline before definition of HookWithKey
411b1ec 
Co-authored-by: Hezekiah Hendry <46537907+RealShadowNova@users.noreply.github.com>
@thetayloredman
change hwk def to unknown
4fd805c
RealShadowNova
RealShadowNova approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@RealShadowNova RealShadowNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RealShadowNova RealShadowNova changed the title feat: add Josh#each() function feat: add each method Apr 12, 2022
@RealShadowNova RealShadowNova changed the title feat: add each method feat: add Josh#each() method Apr 12, 2022
@RealShadowNova RealShadowNova merged commit 4b1fe3d into josh-development:main Apr 20, 2022
@thetayloredman thetayloredman deleted the add-each branch April 20, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealShadowNova RealShadowNova RealShadowNova approved these changes

@dan-online dan-online Awaiting requested review from dan-online dan-online is a code owner

@WilsontheWolf WilsontheWolf Awaiting requested review from WilsontheWolf

Assignees

@thetayloredman thetayloredman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thetayloredman @RealShadowNova