Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set #![deny(warnings)] on the whole crate #1040

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't set #![deny(warnings)] on the whole crate #1040

wants to merge 1 commit into from

Commits on Nov 16, 2022

  1. Don't set #![deny(warnings)] on the whole crate 

    deny(warnings) is generally considered to be a pretty strong
anti-pattern[0] because new warnings can be introduced, either by new
versions of rustc or by new versions of dependencies, that the binary
author may want to prevent but shouldn't prevent users from building
from source. In this case, a newer version of `chrono` deprecated
`NaiveDateTime::from_timestamp`, which ended up breaking my CI pipeline
because josh is no longer able to build.

Generally, instead, it's better practice to deny *specific* warnings, or
build with `-D warnings` in CI.

[0]: https://rust-unofficial.github.io/patterns/anti_patterns/deny-warnings.html
    @glittershark
    glittershark committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    476214f View commit details
    Browse the repository at this point in the history