Fix optimisation bug for compose filter #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/fix-opt-bug
branch
4 times, most recently
from
7ed4d3d
to
ec76766
Compare
LMG
approved these changes
Mar 3, 2023
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/fix-opt-bug
branch
3 times, most recently
from
258f767
to
a0c1d6a
Compare
The optimiser incorrectly transformed :[:/y,:/x/y] into :[:/,:/x]:/y This is not correct because :/y is more restrictive than :/ and will therefore not match all the files that :/ does. Due to the compose filter guaranteeing uniqueness of mappings the led to files missing from the first filter. Change: fix-opt-bug
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/fix-opt-bug
branch
from
a0c1d6a
to
38eecee
Compare
christian-schilling
deleted the
@changes/master/christian.schilling.de@gmail.com/fix-opt-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimiser incorrectly transformed :[:/y,:/x/y] into :[:/,:/x]:/y
This is not correct because :/y is more restrictive than :/ and will
therefore not match all the files that :/ does.
Due to the compose filter guaranteeing uniqueness of mappings
the led to files missing from the first filter.