Fix check-then-act race condition #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2023
Closed
christian-schilling
approved these changes
Sep 30, 2023
All crates in workspace are now 2021 Rust commit-id:e6fac661
The semaphore is aquired after the conditions for fetching are already evaluated. It means that multiple threads/runners can decide to fetch simultaneously and then wait on the same semaphore, even though only one fetch is needed. Therefore, fetch would happen more often than what is specified in fetch times, and requests can be slow under load. commit-id:a4cd58e6
vlad-ivanov-name
force-pushed
the
spr/master/a4cd58e6
branch
from
d5cadf4
to
e542b98
Compare
vlad-ivanov-name
changed the base branch from
spr/master/e6fac661
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semaphore is aquired after the conditions for fetching are already
evaluated. It means that multiple threads/runners can decide to fetch
simultaneously and then wait on the same semaphore, even though only one
fetch is needed. Therefore, fetch would happen more often than what is
specified in fetch times, and requests can be slow under load.
commit-id:a4cd58e6
Stack: