Fixing up formatting and added in ability to chain jQuery functions. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So .. would you mine taking just 653f1c2 and sending that as a pull request? I appreciate the semicolors and 4 spaces and such, but, that seems like more of a style thing. You know, visiting other people's code is like going to a foreign country. Best not to judge, better to just put on the clothes and fit in :) |
|
(Oh, and please toss in 118171c to boot) |
|
No worries man, completely understand. I should be able to just remove that one commit for the formatting from the pull request and leave the other two :) |
…t. Implemented a conditional function for checking IE versions 9 and u
|
Awesome. I seriously appreciate your changes though! I hope you don't mind pulling this into another pr. And happy to improve this in other ways that you dream up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a $(this).each was being used, so I added in a return this.each instead so chainability with other functions is kept intact. I also cleaned some some of the variables and added in missing semicolons and fixed if statements that were short-handed. Some personal preferences with formatting and whatnot might come into play here.
I indented everything 4 spaces which cleans things up too.