feat: allow for multiple descriptions in autocategorization

joshcanhelp · Feb 27, 2024 · a7b7d14 · a7b7d14
1 parent 97d9f8d
commit a7b7d14
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 9 deletions.
diff --git a/src/utils/config.ts b/src/utils/config.ts
@@ -49,7 +49,7 @@ export interface Allowance {
 }
 
 export interface AutoCategorization {
-  description?: string;
+  descriptions?: string[];
   amount?: {
     gt?: number;
     gte?: number;

diff --git a/src/utils/transaction.spec.ts b/src/utils/transaction.spec.ts
@@ -35,7 +35,10 @@ describe("Function: autoCategorize", () => {
   it("auto-categorizes when the description is matched", () => {
     mockTransaction.description = "__TEST_DESCRIPTION__";
     mockConfig.autoCategorization = [{ ...mockAutoCategorization }];
-    mockConfig.autoCategorization[0].description = "TEST_DESCRIPTION";
+    mockConfig.autoCategorization[0].descriptions = [
+      "TEST_DESCRIPTION",
+      "NOT_MATCHING",
+    ];
 
     expect(autoCategorize(mockTransaction, mockConfig)).toEqual(
       mockConfig.autoCategorization[0].categorization
@@ -46,7 +49,10 @@ describe("Function: autoCategorize", () => {
     mockTransaction.description = "__TEST_DESCRIPTION__";
 
     mockConfig.autoCategorization = [{ ...mockAutoCategorization }];
-    mockConfig.autoCategorization[0].description = "NOT_MATCHING";
+    mockConfig.autoCategorization[0].descriptions = [
+      "NOT_MATCHING",
+      "ALSO_NOT_MATCHING",
+    ];
 
     expect(autoCategorize(mockTransaction, mockConfig)).toBeNull();
   });
@@ -136,7 +142,7 @@ describe("Function: autoCategorize", () => {
     mockTransaction.amount = 150;
 
     mockConfig.autoCategorization = [{ ...mockAutoCategorization }];
-    mockConfig.autoCategorization[0].description = "TEST_DESCRIPTION";
+    mockConfig.autoCategorization[0].descriptions = ["TEST_DESCRIPTION"];
     mockConfig.autoCategorization[0].amount = {
       gt: 100,
       lt: 200,
@@ -152,7 +158,7 @@ describe("Function: autoCategorize", () => {
     mockTransaction.amount = 150;
 
     mockConfig.autoCategorization = [{ ...mockAutoCategorization }];
-    mockConfig.autoCategorization[0].description = "NOT_MATCHED";
+    mockConfig.autoCategorization[0].descriptions = ["NOT_MATCHED"];
     mockConfig.autoCategorization[0].amount = {
       gt: 100,
       lt: 200,
@@ -166,7 +172,7 @@ describe("Function: autoCategorize", () => {
     mockTransaction.amount = 250;
 
     mockConfig.autoCategorization = [{ ...mockAutoCategorization }];
-    mockConfig.autoCategorization[0].description = "TEST_DESCRIPTION";
+    mockConfig.autoCategorization[0].descriptions = ["TEST_DESCRIPTION"];
     mockConfig.autoCategorization[0].amount = {
       gt: 100,
       lt: 200,

diff --git a/src/utils/transaction.ts b/src/utils/transaction.ts
@@ -183,11 +183,15 @@ export const autoCategorize = (
   }
 
   for (const matchCriteria of config.autoCategorization) {
-    const { description, amount, categorization } = matchCriteria;
+    const { descriptions, amount, categorization } = matchCriteria;
 
     let matchedDescription = true;
-    if (description) {
-      matchedDescription = transaction.description.includes(description);
+    if (descriptions && descriptions.length) {
+      matchedDescription = false;
+      for (const description of descriptions) {
+        matchedDescription =
+          matchedDescription || transaction.description.includes(description);
+      }
     }
 
     let matchedAmount = true;