Lint/UnusedMethodArgument

This cop flags methods where `&block` is passed to a method, which is a very
common practice. There's also debate[1] as to whether specifying `&block`
explicitly is better than implicitly accepting a block.

[1] rubocop/rubocop-performance#385

.rubocop.yml

@@ -28,6 +28,10 @@ Lint/BooleanSymbol:
     - 'lib/puppet/reference/providers.rb'
     - 'lib/puppet/parameter/value.rb'
 
+# This breaks the ruby convention of passing &block and using block_given?
+Lint/UnusedMethodArgument:
+  Enabled: false
+
 Metrics/AbcSize:
   Enabled: false
 

.rubocop_todo.yml

@@ -623,11 +623,6 @@ Lint/SuppressedException:
     - 'lib/puppet/util/execution.rb'
     - 'util/rspec_grouper'
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
-Lint/UnusedMethodArgument:
-  Enabled: false
-
 Naming/AccessorMethodName:
   Enabled: false