fix groupby with heatmap plot

joshday · May 21, 2024 · 07a99e1 · 07a99e1
1 parent ccc3d20
commit 07a99e1
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/src/OnlineStats.jl b/src/OnlineStats.jl
@@ -114,8 +114,8 @@ include("viz/khist.jl")
 include("viz/khist2d.jl")
 include("viz/partition.jl")
 include("viz/mosaicplot.jl")
-include("viz/recipes.jl")
 include("viz/heatmap.jl")
+include("viz/recipes.jl")
 include("viz/hexlattice.jl")
 include("viz/ash.jl")
 end
diff --git a/src/stats/histograms.jl b/src/stats/histograms.jl
@@ -186,7 +186,7 @@ counts(o::ExpandingHist) = o.counts
 edges(o::ExpandingHist) = o.edges
 
 function _fit!(o::ExpandingHist, y)
-    isfinite(y) || error("ExpandingHist requires finite values.  Found $y.")
+    isfinite(y) || error("ExpandingHist requires `isfinite` values.  Found $y.")
     o.n += 1
 
     # init

diff --git a/src/viz/recipes.jl b/src/viz/recipes.jl
@@ -71,7 +71,7 @@ end
 end
 
 #-----------------------------------------------------------------------# GroupBy
-@recipe function f(o::GroupBy{<:Any, <:Any, <:Union{KHist, ExpandingHist, Hist}})
+@recipe function f(o::GroupBy{<:Any, <:Any, <:Union{KHist, ExpandingHist, Hist, HeatMap}})
     sort!(o.value)
     link --> :all
     for (k, v) in pairs(o.value)
@@ -81,6 +81,19 @@ end
         end
     end
 end
+@recipe function f(o::GroupBy{<:Any, <:Any, <:HeatMap})
+    sort!(o.value)
+    link --> :all
+    layout --> length(o.value)
+    for (i, (k, v)) in enumerate(pairs(o.value))
+        @series begin
+            subplot --> i
+            marginals --> false
+            title --> string(k)
+            v
+        end
+    end
+end
 @recipe function f(o::GroupBy)
     sort!(o.value)
     link --> :all