Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul 16-color styling #271

Merged
merged 9 commits into from
Jul 12, 2021
Merged

Overhaul 16-color styling #271

merged 9 commits into from
Jul 12, 2021

Conversation

joshdick
Copy link
Owner

@joshdick joshdick commented Jun 30, 2021

Note: This pull request contains breaking changes that could require manual updates:

  • onedark.vim's default branch name will be changed from master to main after this PR is merged. Please update your plugin management configuration accordingly.
  • If colors look wrong after consuming the changes in this PR, you are likely using 16-color mode. Please install the latest onedark.vim terminal theme for your terminal emulator and colors should look correct again. If not, please open a new issue.

Changes for 16-color terminal support

  • Regenerate all terminal themes in term/ in light of the below changes.
  • Tweak 16-color styling to allow use of additional background/foreground color independent of 16 base colors
    • For a better experience with two more colors for 16-color users.
    • This assumes that 16-color users are also using of one of the included terminal themes, all of whose corresponding terminal emulators support independent background/foreground colors (two additional colors.)
  • Make ANSI "bright" colors the brighter ones instead of the darker ones.
  • Remove dark red/yellow colors for 16-color terminals (single shade for each.)
    • Enforces use of "bright" [non-greyscale] colors as the default/only choice, for better readability.

* Make ANSI "bright" colors the brighter ones instead of the darker ones
* Remove dark red/yellow from ANSI colors (single shade for each)
* Tweak 16-color styling to allow use of background/foreground color
  independent of 16 base colors
…erminal usage, further misc. tweaks, including s:black
@joshdick joshdick merged commit ad9610c into master Jul 12, 2021
@joshdick joshdick deleted the 16ColorOverhaul branch July 12, 2021 00:00
nfraprado added a commit to nfraprado/onedark.vim that referenced this pull request Jul 17, 2021
Reverting since it made the text in the fzf menu render like a comment,
making it darker. It was great before, so revert.

This reverts commit ad9610c.
@ckipp01 ckipp01 mentioned this pull request Jul 23, 2021
2 tasks
ckolos added a commit to ckolos/onedark.vim that referenced this pull request Feb 27, 2022
* joshdick-main:
  Lighten up cursor_grey
  Fix misleading example in README. (joshdick#291)
  Update Neovim LSP colors (joshdick#288)
  Add Selection colors for alacritty (joshdick#283)
  Add monsonjeremy/onedark.nvim to relative section (joshdick#282)
  chore: Update old "master" branch refernces to use "main" instead (joshdick#277)
  Overhaul 16-color styling (joshdick#271)
  chore(build): Build/linting infrastructure updates. (joshdick#276)
  chore(plugins): Add list of supported plugins to README, update companion links (joshdick#275)
  feat(plugin): Add support for lewis6991/gitsigns.nvim (joshdick#274)
  fix(nvim-lsp): Make nvim-lsp highlighting consistent with existing related highlighting (joshdick#273)
  fix: prabirshrestha/vim-lsp is not Neovim LSP :) (joshdick#270)
  Improve Neovim LSP highlighting (joshdick#269)
  feat: Add higlight groups for neoclide/coc.nvim (joshdick#268)
  Added navarasu/onedark.nvim to relative section (joshdick#266)
  Add KDE Konsole colorscheme (joshdick#265)
  chore(build): Update dependencies and regenerate lockfile (joshdick#267)
  README.md: Add link to ii14/onedark.nvim in "relatives" section (joshdick#261)
  fix: upgrade termcolors from 0.7.2 to 0.7.3 (joshdick#258)
  Bump lodash from 4.17.20 to 4.17.21 in /build (joshdick#256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant